Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: [netbsd-10] src/sys



Module Name:    src
Committed By:   martin
Date:           Mon Sep 11 13:30:36 UTC 2023

Modified Files:
        src/sys/arch/i386/stand/efiboot [netbsd-10]: efipxe.c
        src/sys/stand/efiboot [netbsd-10]: efipxe.c

Log Message:
Pull up following revision(s) (requested by rin in ticket #362):

        sys/arch/i386/stand/efiboot/efipxe.c: revision 1.2
        sys/stand/efiboot/efipxe.c: revision 1.3

MI and x86 efiboot: Fix device path type for PXE boot device.
It should be Messaging, not Media Device Path. Taken from OpenBSD, for
which this code was originally written:
https://cvsweb.openbsd.org/src/sys/arch/amd64/stand/efiboot/efipxe.c#rev1.6

Network-based device paths use Messaging and not Media types.  Thus
in reality the depth was always -1 which made the compare function
a No-Op.  Properly check the device path depth value and look for
the Messaging type instead to find the correct NIC.  This check
never worked before and was uncovered by the last change.

Regression noticed by bluhm@


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.1.36.1 src/sys/arch/i386/stand/efiboot/efipxe.c
cvs rdiff -u -r1.2 -r1.2.32.1 src/sys/stand/efiboot/efipxe.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index