CVS commit: src

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Fri Jan  1 19:11:20 UTC 2021

Modified Files:
        src/tests/usr.bin/xlint/lint1: d_init_pop_member.c
            d_init_pop_member.exp
        src/usr.bin/xlint/lint1: init.c

Log Message:
lint: fix wrong warning about bitfield in C99 structure initialization

The variable namemem is supposed to be a circular list, which is
"documented" implicitly in push_member.

The implementation was buggy though.  In pop_member, the circular list
was destroyed though.  Given the list (capital, major, favorite_color,
green), removing capital made major point to itself in the forward
direction, even though it should not have been modified at all.

In the test, I had been too optimistic to quickly understand the code
around variable initialization.  I was wrong though, so I had to adjust
the comments there to reality.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/tests/usr.bin/xlint/lint1/d_init_pop_member.c \
    src/tests/usr.bin/xlint/lint1/d_init_pop_member.exp
cvs rdiff -u -r1.51 -r1.52 src/usr.bin/xlint/lint1/init.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.