CVS commit: src/sys

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

Module Name:    src
Committed By:   riastradh
Date:           Tue Dec 22 01:07:23 UTC 2020

Modified Files:
        src/sys/dev/usb: ehci.c ohci.c uhci.c xhci.c
        src/sys/external/bsd/dwc2: dwc2.c

Log Message:
usb: Omit bogus assertions about struct usbd_pipe::up_intrxfer.

These assertions were only valid for pipes at UE_IN_DIR, UE_INTERRUPT
endpoints created with usbd_open_pipe_intr, which uses up_intrxfer to
pass the struct usbd_xfer object to usbd_close_pipe to free later.

In contrast, for pipes at UE_OUT_DIR, UE_INTERRUPT endpoints,
up_intrxfer is never initialized, so the assertion cannot be right.
In principle we might even have more than one outstanding interrupt
transfer at a time, rendering the point of the assertion moot anyway.

Found by interrupting a uhidev write to a u2f device.

ok nick


To generate a diff of this commit:
cvs rdiff -u -r1.283 -r1.284 src/sys/dev/usb/ehci.c
cvs rdiff -u -r1.313 -r1.314 src/sys/dev/usb/ohci.c
cvs rdiff -u -r1.304 -r1.305 src/sys/dev/usb/uhci.c
cvs rdiff -u -r1.135 -r1.136 src/sys/dev/usb/xhci.c
cvs rdiff -u -r1.74 -r1.75 src/sys/external/bsd/dwc2/dwc2.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.