CVS commit: src/usr.bin/make

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Sun Aug 30 13:53:02 UTC 2020

Modified Files:
        src/usr.bin/make: job.c

Log Message:
make(1): remove ineffective malloc_options variable

According to jemalloc(3), the variable must be called _malloc_options,
with a leading underscore, to have an effect.

Renaming the variable indeed enables the option.  There's not much point
having this variable around though, since it neither detects a trivial
double-free nor freeing an invalid pointer in the following code
snippet:

        char *asdf = bmake_malloc(10);
        fprintf(stderr, "%c\n", *asdf);
        free(asdf + 8);
        free(asdf);
        free(asdf);
        exit(1);

Instead, it just crashes with a segmentation fault.


To generate a diff of this commit:
cvs rdiff -u -r1.225 -r1.226 src/usr.bin/make/job.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.