Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: [netbsd-9] src/sys



Module Name:    src
Committed By:   martin
Date:           Mon May 18 18:12:25 UTC 2020

Modified Files:
        src/sys/arch/amd64/conf [netbsd-9]: GENERIC
        src/sys/arch/evbarm/conf [netbsd-9]: GENERIC GENERIC64
        src/sys/arch/hppa/include [netbsd-9]: param.h
        src/sys/arch/m68k/include [netbsd-9]: param.h
        src/sys/arch/sh3/include [netbsd-9]: param.h
        src/sys/arch/sparc/include [netbsd-9]: param.h
        src/sys/arch/vax/include [netbsd-9]: param.h
        src/sys/dev/audio [netbsd-9]: audio.c audiodef.h

Log Message:
Pull up following revision(s) (requested by isaki in ticket #911):

        sys/dev/audio/audiodef.h: revision 1.13
        sys/dev/audio/audiodef.h: revision 1.14
        sys/arch/sparc/include/param.h: revision 1.74
        sys/arch/evbarm/conf/GENERIC64: revision 1.148
        sys/arch/sh3/include/param.h: revision 1.25
        sys/arch/evbarm/conf/GENERIC: revision 1.75
        sys/arch/m68k/include/param.h: revision 1.23
        sys/arch/amd64/conf/GENERIC: revision 1.564
        sys/arch/hppa/include/param.h: revision 1.27
        sys/dev/audio/audio.c: revision 1.68
        sys/arch/vax/include/param.h: revision 1.63
        sys/dev/audio/audio.c: revision 1.69

Reduce default AUDIO_BLK_MS from 40msec to 10msec on all platform except m68k
(m68k uses 40msec default as before).  And remove the option from GENERIC.

- It's not good idea to set such parameter in individual GENERICs.
- 4msec is (probably no problem for most modern real hardware but)
  too aggressive to be default.
- 10msec is too severe for antique machines but it's hard to draw a line.

Set AUDIO_BLK_MS 40 msec on other old(slow) architectures not only m68k.

Thanks tsutsui@ for comment about architecture choice.
And move it from audiodef.h to audio.c as suggested by joerg@.

Move machine dependent AUDIO_BLK_MS default value to <machine/param.h>.
If the port has __AUDIO_BLK_MS in <machine/param.h>, it will be used.

Otherwise the default value (currently 10 msec) defined in audio.c will
be used.  This mechanism is for very old ports which cannot satisfactorily
handle 10 msec block.  Currently hppa, m68k, sh3, sparc(!64) and vax are.

For port maintainers, if general models in your port cannot satisfactorily
handle 10 msec block, please consider to define your suitable longer period
(40 msec would be a good first choice).

But please don't be eager to make the default value shorter.
<machine/param.h> was discussed in source-changes-d.  It's better than
ifdef storm, or adding 60+ new header files in every arch/*/include/
directories for this.  Thanks mrg@, ad@, and everyone.
http://mail-index.netbsd.org/source-changes-d/2020/05/01/msg012572.html


To generate a diff of this commit:
cvs rdiff -u -r1.531.2.8 -r1.531.2.9 src/sys/arch/amd64/conf/GENERIC
cvs rdiff -u -r1.48.2.7 -r1.48.2.8 src/sys/arch/evbarm/conf/GENERIC
cvs rdiff -u -r1.103.2.9 -r1.103.2.10 src/sys/arch/evbarm/conf/GENERIC64
cvs rdiff -u -r1.23 -r1.23.4.1 src/sys/arch/hppa/include/param.h
cvs rdiff -u -r1.22 -r1.22.4.1 src/sys/arch/m68k/include/param.h
cvs rdiff -u -r1.24 -r1.24.4.1 src/sys/arch/sh3/include/param.h
cvs rdiff -u -r1.73 -r1.73.2.1 src/sys/arch/sparc/include/param.h
cvs rdiff -u -r1.62 -r1.62.4.1 src/sys/arch/vax/include/param.h
cvs rdiff -u -r1.28.2.14 -r1.28.2.15 src/sys/dev/audio/audio.c
cvs rdiff -u -r1.7.2.3 -r1.7.2.4 src/sys/dev/audio/audiodef.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index