CVS commit: src/sys/dev/ic

["SAITOH Masanobu" <msaitoh%netbsd.org@localhost>]

Module Name:    src
Committed By:   msaitoh
Date:           Sat Feb  8 08:23:01 UTC 2020

Modified Files:
        src/sys/dev/ic: aic79xx_inline.h

Log Message:
Apply FreeBSD r357300:

 > aic7xxx(4): Fix unintended sign extension in ahd_inq()
 >
 > ahd_inb() returns type uint8_t.  The shift left by untyped 24 implicitly
 > promotes the result to type (signed) int.  Then the binary OR with uint64_t
 > values sign-extends the integer.  If bit 31 of the read value happened to be
 > set, the 64-bit result would have all upper 32 bits set to 1 due to OR.
 > This is clearly not intended.
 >
 > Reported by: Coverity
 > CID:         980473 (old one!)


To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.23 src/sys/dev/ic/aic79xx_inline.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.