Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/usr.bin/printf



Module Name:    src
Committed By:   kre
Date:           Mon Sep 10 14:42:29 UTC 2018

Modified Files:
        src/usr.bin/printf: printf.c

Log Message:
A truly ancient bug found by Edgar Fuss

When printf is running builtin in a sh, global vars aren't reset to
0 between invocations.   This affects "rval" which remembers state
from a previous %b \c and thereafter always exits after the first
format conversion, until we get a conversion that generates an
error (which resets the flag almost by accident)

        printf %b abc\\c
        abc                             (no \n)
        printf %s%s hello world
        hello                           (no \n, of course, no world ...)
        printf %s%s hello world
        hello
        printf %s%s hello world
        hello
        printf %d hello
        printf: hello: expected numeric value
        0                               (no \n)
        printf %s%s hello world
        helloworld                      (no \n, and we are back!)

This affects both /bin/sh and /bin/csh (and has for a very long time).

XXX pullup -8


To generate a diff of this commit:
cvs rdiff -u -r1.45 -r1.46 src/usr.bin/printf/printf.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index