Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: [netbsd-8] src/sys/dev

Module Name:    src
Committed By:   snj
Date:           Mon Sep 11 05:33:23 UTC 2017

Modified Files:
        src/sys/dev [netbsd-8]: audio.c

Log Message:
Pull up following revision(s) (requested by isaki in ticket #274):
        sys/dev/audio.c: 1.379, 1.380, 1.385, 1.398
Fix error handling of ring buffers allocation in audioattach().
NULL dereference, dead code, reference to uninitialized variable,
and mutex leak.
XXX In the current implementation, if audio_alloc_ring() returns error,
    it is not guaranteed that ringbuf->s.start will be NULL.
Fix a resource leak on error handling in audio_alloc_ring().
Fix resource leaks on error handling in audio_open().
Avoid possibility of integer overflow (and clean up).
- On 32bit arch and type argument is int32_t, orig[m] * tomix[m] is
  calculated first with int32 (possibility of overflow here) and then
  cast to int64_t for assignment.
- bigger_type is sufficient for product and result.

To generate a diff of this commit:
cvs rdiff -u -r1.357.2.6 -r1.357.2.7 src/sys/dev/audio.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index