Re: CVS commit: src/sys/dev/pci

[David Young <dyoung%pobox.com@localhost>]

On Sat, Jan 31, 2009 at 01:57:03PM +0000, Manuel Bouyer wrote:
> 
> Module Name:  src
> Committed By: bouyer
> Date:         Sat Jan 31 13:57:03 UTC 2009
> 
> Modified Files:
>       src/sys/dev/pci: if_jme.c
> 
> Log Message:
> Under some circunstance, the JMC250A2 (and maybe others) can enter a state
> where INTA is asserted while no enabled interrupts are pending, which
> cause a continous strean if interrupts with no way to clear it.
> Clearing/resetting the enabled interrupt mask in the interrupt handler seems
> to workaround this issue (this is what the FreeBSD driver does).
> While there properly return 0 if the interrupt was not for us, and explicitely
> disable JME_TMCSR in addition to TIMER1 and TIMER2.

Does FreeBSD enable/disable by changing the interrupt mask on the
NIC because that is the right / only workaround for this bug, or
do they do that because the change has been carried by the cargo
cult from driver to driver to driver?  Maybe you should disable/enable
only if INTA seems to be stuck?

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933