Re: CVS commit: src/usr.bin/make

[Matt Fleming <mjf%netbsd.org@localhost>]

On Sun, Jan 18, 2009 at 12:50:15PM +0000, David Laight wrote:
> 
> Module Name:  src
> Committed By: dsl
> Date:         Sun Jan 18 12:50:15 UTC 2009
> 
> Modified Files:
>       src/usr.bin/make: cond.c
> 
> Log Message:
> Only terminate a conditional function argument on ')' if we expect the
> argument to be exclosed in (...).
> '.if exists()' is parsed as '.ifdef exists()' and the ')' must not be
> left over at the end.
> I have no idea why any of my recent changes have affected this.
> But pkgsrc/mk/compiler/gcc.mk (line 488) does .if exists(${FCPATH})
> even though FCPATH is only set when the file exists.
> 

With this change make fails to parse this conditional in
sys/lib/libkern/Makefile,


.ifndef(ARCHSUBDIR)
.BEGIN:
        @echo no ARCHSUBDIR for ${MACHINE_ARCH} nor ${MACHINE_CPU}
        @false
.endif

Bombing with,

nbmake: "/home/mjf/src/NetBSD/clean/src/sys/lib/libkern/Makefile" line
8: Malformed conditional ((ARCHSUBDIR))
nbmake: Fatal errors encountered -- cannot continue