Re: CVS commit: src/sys

[Frank Kardel <kardel%netbsd.org@localhost>]

Hi Martin !

Sorry - no luck (same error as before) with:
Index: if_spppsubr.c
===================================================================
RCS file: /cvsroot/src/sys/net/if_spppsubr.c,v
retrieving revision 1.115
diff -u -r1.115 if_spppsubr.c
--- if_spppsubr.c       7 Nov 2008 00:20:13 -0000       1.115
+++ if_spppsubr.c       9 Nov 2008 21:24:01 -0000
@@ -1048,8 +1048,6 @@
               break;

       case SIOCSIFFLAGS:
-               if ((error = ifioctl_common(ifp, cmd, data)) != 0)
-                       break;
               going_up = ifp->if_flags & IFF_UP &&
                       (ifp->if_flags & IFF_RUNNING) == 0;
               going_down = (ifp->if_flags & IFF_UP) == 0 &&
@@ -1061,6 +1059,9 @@
                       ifp->if_flags &= ~IFF_AUTO;
               }

+               if ((error = ifioctl_common(ifp, cmd, data)) != 0)
+                       break;
+
               if (going_up || going_down)
                       lcp.Close(sp);
               if (going_up && newmode == 0) {

Maybe I got the wrong spot - but why would ifioctl_common be influenced 
at all by moving it there ?

Frank

Martin Husemann wrote:
> On Sat, Nov 08, 2008 at 01:30:34PM +0100, Frank Kardel wrote:
>   
> > Hi David !
> >
> > After this commit pppoe broke (new kernel no userland upgrade) at my site 
> > with:
> >
> > 2008-11-08T09:48:33.270324+01:00 pip.kardel.name /netbsd - - - pppoe0: ipcp 
> > illegal conf-req in state initial
> >     
>
> Can you try moving the call to ifioctl_common in the SIOCSIFFLAGS case
> a few lines down untill after newmode is calculated?
>
> Martin
>