Re: CVS commit: src/sys/nfs

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Fri Oct 17 2008 at 14:24:43 +0000, Christos Zoulas wrote:
> 
> Module Name:  src
> Committed By: christos
> Date:         Fri Oct 17 14:24:43 UTC 2008
> 
> Modified Files:
>       src/sys/nfs: nfs_bio.c
> 
> Log Message:
> Requested by yamt:
> - In getpages don't allocate if we are not locked
> - Use kmem_alloc instead of malloc and don't sleep
> 
> Also provide a 64 entry stack array so we don't have to allocate in the
> common case.

This is a ridiculous limit since genfs currently panics with pagecount
of over 16.  You could unify the magic onstack constant with genfs
so that we don't have random constants all over the place.  Also, you
could shortcircuit the allocation so that you don't always unnecessarily
allocate for unapplicable faults such as read faults.