Re: CVS commit: src

[christos%astron.com@localhost (Christos Zoulas)]

In article <20081010113548.GW18185%hairylemon.org@localhost>,
Andrew Doran  <ad%netbsd.org@localhost> wrote:
>> Module Name:    src
>> Committed By:   tls
>> Date:           Mon Aug  4 03:55:48 UTC 2008
>> 
>> Modified Files:
>>         src/sys/arch/i386/conf: GENERIC XEN2_DOM0 XEN2_DOMU
>>         src/sys/conf: files
>>         src/sys/kern: uipc_socket.c uipc_socket2.c
>>         src/sys/sys: socket.h socketvar.h
>>         src/usr.sbin/inetd: inetd.c
>> Added Files:
>>         src/sys/kern: uipc_accf.c
>>         src/sys/netinet: accept_filter.h accf_data.c accf_http.c
>> 
>> Log Message:
>> Add accept filters, ported from FreeBSD by Coyote Point Systems.  Add inetd
>> support for specifying an accept filter for a service (mostly as a usage
>> example, but it can be handy for other things).  Manual pages to follow
>> in a day or so.
>> 
>> OK core@.
>
>- Why does this sprinkle #ifdef INET into the socket code?
>- The locking is stubbed out which means it is unsafe.
>- It should use kmem_alloc() and not malloc().
>- Did core@ bother to review it?

It was posted in tech-kern I believe.

christos