Re: CVS commit: src/sys/ufs/ffs

[Simon Burge <simonb%NetBSD.org@localhost>]

Alan Barrett wrote:

> On Mon, 08 Sep 2008, Joerg Sonnenberger wrote:
> > Log Message:
> > Move successful removal of unreferenced inodes under WAPBL_DEBUG to not
> > spam the console.
> 
> I think that such messages are the moral equivalent of what fsck would
> print with a non-wapbl file system, so I'd prefer them not to be
> completely hidden by default.  However, I can see that many people would
> not want them.  I suggest a compromise of a single summary message with
> a count of removed inodes.

These messages are refering to files that had been scheduled to be
removed but weren't before a crash/reboot/etc had occurred.  In that
respect, they're a bit different to say an fsck message where something
unexpected would have happened.  You could go the other way and say you
want the WAPBL replay code to dump a summary of all inodes/directory
blocks that were replayed too (which I am definitely _not_ arguing
for!).

> Also, WAPBL_DEBUG seems to be undocumented.  It's not in options(4), and
> it's not present as a commented-out option in src/sys/arch/*/conf/*.

Without looking, I'd guess there'd be a heap of driver-specific
FOO_DEBUG options that aren't documented anywhere but in the relevent
source code files.

Simon.