[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/cardbus
From: Christoph Egger <Christoph_Egger%gmx.de@localhost>
Date: Fri, 11 Jul 2008 23:16:30 +0200
> KIYOHARA Takashi wrote:
> > Module Name: src
> > Committed By: kiyohara
> > Date: Fri Jul 11 17:50:45 UTC 2008
> > Modified Files:
> > src/sys/dev/cardbus: fwohci_cardbus.c
> > Log Message:
Fix forgotten that change by drochner since Tue Jun 24 19:44:52 2008 UTC.
> > clean up the cardbus interrupt stuff:
> > There were cardbus_intr_line_t and cardbus_intr_handle_t used intermixed
> > for the same variable, and that variable is pretty much useless because
> > cardbus doesn't follow the PCI interrupt swizzling etc scheme.
> > Useless interrupt numbers were printed on cardbus device attach.
> > So as a first step to sanity, kill cardbus_intr_handle_t and poison
> > cardbus_intr_line_t to discourage printing it as a %d.
> > Use cardbus_intr_line_t consistently throughout the code.
> > Remove the "interrupting at foo" messages because the information
> > is misleading. We could come up with a better interrupt vector
> > information, but because cardbus interrupts are mediated by pccbb
> > it would still be misleading.
> > To generate a diff of this commit:
> > cvs rdiff -r1.25 -r1.26 src/sys/dev/cardbus/fwohci_cardbus.c
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> Are you sure, you committed the correct file or all files ?
> I'm just wondering because the diff does not match the commit log.
If the date and those who change are added, can you understand?
# I will change to the commit log yet. ;-)
Main Index |
Thread Index |