Re: CVS commit: src/sys/arch

[Matthias Drochner <M.Drochner%fz-juelich.de@localhost>]

simonb%NetBSD.org@localhost said:
> >     src/sys/arch/amd64/amd64: machdep.c
> >     src/sys/arch/i386/i386: machdep.c
> > [...]
> > Leave interrupts on for the shutdownhooks. Should fix the panics on
> > shutdown. 
> the logic of leaving interrupts enabled before
> calling the shutdown hooks needs to be applied to ~every other port as
> well

I'm afraid this goes into the wrong direction. Shutdownhooks up to
now assume that interrupts are already disabled and use polling
mode or so if needed. Generally, only a minimum should be done
anyway, and sleeping in a shutdown handler is too much.
The hooks are also run after a panic, where interrupts are not
available anyway.
Also, after a dumpsys(9), the disk driver is in a state usually
where one can't do any normal operation anymore, just polled things.

If there was just a single driver installing a shutdown handler
assuming interrupts, that one should be fixed.

best regards
Matthias




-------------------------------------------------------------------
-------------------------------------------------------------------
Forschungszentrum Juelich GmbH
52425 Juelich

Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzende des Aufsichtsrats: MinDir'in Baerbel Brumme-Bothe
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Dr. Ulrich Krafft (stellv. Vorsitzender), Prof. Dr. Harald Bolt,
Dr. Sebastian M. Schmidt
-------------------------------------------------------------------
-------------------------------------------------------------------