Re: CVS commit: src

[Havard Eidnes <he%NetBSD.org@localhost>]

> Module Name:  src
> Committed By: ad
> Date:         Tue May 20 19:01:11 UTC 2008
>
> Modified Files:
>       src/distrib/sets: sets.subr
>       src/distrib/sets/lists/base: lkm.mi md.i386 mi
>       src/etc/mtree: NetBSD.dist
>       src/share/mk: bsd.kmodule.mk bsd.own.mk
> 
> Log Message:
> Install kernel modules into the proper locations, taking machine and
> kernel version into account.

A couple of comments on this:

1) This does not appear to have been tested with a full release
   build.  The reason I beleive that is that all my local builds
   now bomb out when processing the set lists because only the
   /stand/ and /stand/<machine>/<os-version>/<module>/
   directories are defined in the set lists, and mtree complains
   bitterly because /stand/<machine>/ isn't defined anywhere:

checkflist ===> distrib/sets
nbmtree: ./stand/algor: No such file or directory
nbmtree: failed at line 27157 of the specification

*** Failed target:  /u/build/HEAD/dest/algor/METALOG.sanitised
*** Failed command: ( cat /u/build/HEAD/src/etc/mtree/NetBSD.dist ; echo 
'/unset all' ; cat /u/build/HEAD/dest/algor/METALOG ) | 
/u/build/HEAD/tools/algor/bin/nbmtree -C -k all -N /u/build/HEAD/src/etc > 
/u/build/HEAD/dest/algor/METALOG.new && ( rm -f 
/u/build/HEAD/dest/algor/METALOG ; mv /u/build/HEAD/dest/algor/METALOG.new 
/u/build/HEAD/dest/algor/METALOG )
*** Error code 1

2) /stand/ is actually the wrong place.  Traditionally, /stand/
   has been reserved for stand-alone binaries (hier(7) says
   "programs used in a standalone environment"), i.e. things
   which run on the bare metal without a kernel.  Kernel modules
   do not fall into that category.  I'd rather use /kmod/ or
   /kernel/ or something like that.

Do I need to send-pr this?

Regards,

- Håvard