Re: CVS commit: src/sys

[christos%zoulas.com@localhost (Christos Zoulas)]

On May 6,  1:36am, ad%netbsd.org@localhost (Andrew Doran) wrote:
-- Subject: Re: CVS commit: src/sys

| On Mon, May 05, 2008 at 12:34:42AM +0000, Christos Zoulas wrote:
| 
| > In article <20080504230709.C4F56175D0%cvs.netbsd.org@localhost>,
| > Andrew Doran  <ad%netbsd.org@localhost> wrote:
| > >
| > >Module Name:       src
| > >Committed By:      ad
| > >Date:              Sun May  4 23:07:09 UTC 2008
| > >
| > >Modified Files:
| > >   src/sys/conf: files
| > >   src/sys/dev: vnd.c
| > >   src/sys/net: ppp-deflate.c
| > >   src/sys/netinet6: ipcomp_core.c ipcomp_input.c ipcomp_output.c
| > >   src/sys/opencrypto: deflate.c deflate.h
| > >Added Files:
| > >   src/sys/kern: kern_zlib.c
| > >   src/sys/sys: zlib.h
| > >Removed Files:
| > >   src/sys/net: zlib.c
| > >
| > >Log Message:
| > >Move zlib out of net/ and into kern/. It would probably be better to use
| > >the reachover Makefiles and libz, but this is already here and it works.
| > >
| > >Please note that diffs are not public domain; they are subject to the
| > >copyright notices on the relevant files.
| > 
| > I don't think this is a good idea. This is an ancient hacked version of libz
| > specially hacked to handle what ppp wants. I don't think it is wise to 
expand
| > its use.
| 
| Ok, I backed it out but I'm not sure where to go from here. The zlib under
| net/ works for what I'm doing but it does look stale. Originally I thought
| it would be better to use something other than gzip compression on the
| firmware images, but it's used everywhere and there seems no point in using
| another method just for the heck of it. So I'd like to include zlib in the
| kernel but it seems dumb to have two copies of it. Maybe after 5.0 is
| branched we could work on making ppp and ipsec use a standard zlib. What do
| you think?

It is not as easy as it seems, but I will try. I have tried to merge them
in the past with not much success.

christos