Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/sys/dev/ic



Quoting David Young <dyoung%pobox.com@localhost>:
On Sun, May 04, 2008 at 08:02:06PM +0000, Stephen M. Rumble wrote:

Module Name:  src
Committed By: rumble
Date:         Sun May  4 20:02:06 UTC 2008

Modified Files:
      src/sys/dev/ic: ath.c

Log Message:
If a device transmit timeout occurs and sc_txintrperiod is greater than
one, throttle it down before the reset. This way the user need not know
the magic `hw.ath0.txintrperiod=1' fix if the default value is too high
for their machine.

What does it mean for the default value to be too high for a particular
machine?

Aside from device timeouts occurring or not, I have no idea.

I think that this is just covering up a bug in NetBSD.

There may be a bug, but it hasn't been fixed and it seems that users are happy with setting the value lower.

This patch does not cover anything up. It will still print timeouts as well as the fact that sc_txintrperiod has been lowered. I think this is better than having somebody set a value in /etc/sysctl.conf and never seeing the error again and always taking a performance hit if it is someday fixed.

Steve



Home | Main Index | Thread Index | Old Index