Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



On 19-Apr-2008 Joerg Sonnenberger wrote:
> If they are not important enough to be noticable, why are you using
> aprint_error in first place? Or printf for that matter. If you really
> don't want to see them, you can use the boot flags to silence them, they
> are still going into dmesg.

The things I want to see at boot and the things I want to see at runtime are
two different sets.  Thats why I think we are supposed to use log there.  The
boot flags are intended to affect the autoconf/bootup messages, not normal
operation.  log() lets the decision of where those messages get displayed be
decided by the user.  Perhaps the user wants to see verbose things about the
probing, but doesn't want the console spammed during operation, error or not. 
Perhaps what he wants is the console to be nice and clean and have syslog write
them out, and his little monitoring script to pick them up from the logs.  We
should let the user decide, not decide for him.

My problem with aprint_error in normal operation is that I can't shut it up.  I
don't consider a boot time flag a reasonable solution to that when we have a
perfectly good facility for it already.

---
Tim Rightnour <root%garbled.net@localhost>
NetBSD: Free multi-architecture OS http://www.netbsd.org/
Genecys: Open Source 3D MMORPG: http://www.genecys.org/


Home | Main Index | Thread Index | Old Index