Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/ic



On Sat, Apr 19, 2008 at 05:27:13AM +0900, Izumi Tsutsui wrote:
> > Nothing in the man page says they are limited to use during
> > autoconfiguration.
> 
> "intended to be used to print autoconfiguration messages" isn't enough?

No, it just gives the most prominent use for the API.

> It also says aprint_error(9) is prepared "to report the number of errors
> that occurred during a quiet or silent initialization phase."

Yes and the same can be done later as well. E.g. it could print all
error messages to the console in RED BLINKING letters.

> Anyway, I think actual error accounting should be done by APIs
> like evcnt(9) rather than current aprint(9) family.

There's a difference between errour accounting and tagging error
messages semantically. You have changed one case of multiple hundred
commits to change most messages during normal and abnormal operatorion
to a semantic interface back to the old way. The inquiry was not
contested and the only point raised against this change was a complain
about the verbosity of the function names and the "flexibility" of the
interface. On that base I ask you again to change this part of the
change back to what it was before your commit.

Joerg


Home | Main Index | Thread Index | Old Index