Re: CVS commit: src/sys/arch/xen/x86

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

On Thu, Apr 17, 2008 at 12:24:44PM +0000, Christoph Egger wrote:
> 
> Module Name:  src
> Committed By: cegger
> Date:         Thu Apr 17 12:24:44 UTC 2008
> 
> Modified Files:
>       src/sys/arch/xen/x86: cpu.c
> 
> Log Message:
> reduce diff to x86/x86/cpu.c


+#if NLAPIC > 0
+               /*
+                * Enable local apic
+                */
+               lapic_enable();
+               lapic_set_lvt();
+               lapic_calibrate_timer(ci);
+#endif
+#if NIOAPIC > 0
+               ioapic_bsp_id = caa->cpu_number;
+#endif


I think this is wrong. You're now overwriting ioapic_bsp_id, which was already
initialised by cpu_attach(), with virtual CPU data.

Now it looks like ioapic_bsp_id is write-only, so maybe it should just go.

-- 
Manuel Bouyer <bouyer%antioche.eu.org@localhost>
     NetBSD: 26 ans d'experience feront toujours la difference
--