Re: CVS commit: src/usr.bin/printf

[christos%zoulas.com@localhost (Christos Zoulas)]

On Mar 29,  8:09am, kardel%netbsd.org@localhost (Frank Kardel) wrote:
-- Subject: Re: CVS commit: src/usr.bin/printf

| Hi Christos !
| 
| There may be a small issue with this when compiling sh... the compiler 
| also detects more errors :-)
| 
| Christos Zoulas wrote:
| > Module Name:        src
| > Committed By:       christos
| > Date:               Fri Mar 28 18:05:39 UTC 2008
| >
| > Modified Files:
| >     src/usr.bin/printf: printf.c
| >
| > Log Message:
| > detect more errors from printf/malloc.
| >
| >
| > To generate a diff of this commit:
| > cvs rdiff -r1.31 -r1.32 src/usr.bin/printf/printf.c
| >
| > Please note that diffs are not public domain; they are subject to the
| > copyright notices on the relevant files.
| >   
| #   compile  sh/printf.o
| /usr/btools/bin/i386--netbsdelf-gcc -O2 -pipe  -Wall -Wstrict-prototypes 
| -Wmissing-prototypes -Wpointer-arith -Wno-sign-compare -Wno-traditional 
| -Wreturn-type -Wswitch -Wshadow -Wcast-qual -Wwrite-strings -Wextra 
| -Wno-unused-parameter -std=gnu99  -Werror  -DSHELL -I. 
| -I/src/NetBSD/tc-merge/src/bin/sh -nostdinc -isystem /usr/include   
| -c    /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c
| cc1: warnings being treated as errors
| /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c: In function 
| 'printfcmd':
| /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c:132: warning: 
| declaration of 'error' shadows a global declaration
| 
/fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/../../bin/sh/bltin/bltin.h:87:
 
| warning: shadowed declaration is here
| /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c:214: error: 
| void value not ignored as it ought to be
| /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c:214: error: 
| void value not ignored as it ought to be
| /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c:214: error: 
| void value not ignored as it ought to be
| /fs/raid1a/src/NetBSD/tc-merge/src/usr.bin/printf/printf.c:214: error: 
| void value not ignored as it ought to be
| ...

Argh, I should have tried that. I will fix it.

christos