Subject: CVS commit: [netbsd-4] src/sys/fs/msdosfs
To: None <source-changes@NetBSD.org>
From: Jeff Rizzo <riz@netbsd.org>
List: source-changes
Date: 02/01/2008 14:50:27
Module Name: src
Committed By: riz
Date: Fri Feb 1 14:50:27 UTC 2008
Modified Files:
src/sys/fs/msdosfs [netbsd-4]: msdosfs_vnops.c
Log Message:
Pull up following revision(s) (requested by pooka in ticket #1007):
sys/fs/msdosfs/msdosfs_vnops.c: revision 1.43
Fix a problem noticed by Reinoud: the fs would try to release an
unlocked vnode when trying to rename a directory. The fix was to
shuffle some bits around and #pray.
The rename routine actually needs a very very major wide-angle whopping:
* it takes locks out-of-order
* it deals with references from SAVESTART lookups in interesting ways
* I doubt there is any guarantee for correct operation if there
are multiple concurrent accesses
* the error branches might just as well call panic() directly
To generate a diff of this commit:
cvs rdiff -r1.34.2.1 -r1.34.2.2 src/sys/fs/msdosfs/msdosfs_vnops.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.