Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: [yamt-lazymbuf] src/sys/arch/amd64/include



On Mon, Jan 21, 2008 at 10:43:12AM +0000, YAMAMOTO Takashi wrote:
> Log Message:
> remove __HAVE_LAZY_MBUF for now as it's incompatible with in_cksum.S.

Having read the necessary changes, I am not sure I like the current
approach. Can we use two flags please, one to annotate that the current
mbuf is external, but not mapped and one to annotate that this mbuf
chain might have such a mapping? That way we can keep the complexity out
of a few routines and have a simple

        if (mbuf_chain_is_lazy(m)) map_mbuf_chain(m)

at the beginning of the glue code e.g. for in_cksum. I would expect this
to apply to a few other cases where we just have to deal with the whole
mbuf anyway.

Joerg



Home | Main Index | Thread Index | Old Index