Re: CVS commit: src/sys/kern

[David Young <dyoung%pobox.com@localhost>]

On Fri, Jan 18, 2008 at 01:22:18AM +0000, Joerg Sonnenberger wrote:
> 
> Module Name:  src
> Committed By: joerg
> Date:         Fri Jan 18 01:22:18 UTC 2008
> 
> Modified Files:
>       src/sys/kern: kern_subr.c
> 
> Log Message:
> Short cut doshutdownhooks on panic. The system is wedged and so avoid
> anything that could make the status worse.

I think that this change was premature.

NetBSD has run the pre-PMF shutdown hooks after panic for years.  I have
not heard anyone complaining about them.  Is there a particular bug you
fix by skipping them at panic?

The call to pmf_system_shutdown() is new.  If it causes problems after
a panic, I believe that this conservative change is more appropriate:
check for panic and quit after running the "legacy" shutdown hooks,
but before running pmf_system_shutdown().

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933 ext 24