On Thu, 17 Jan 2008, David Young wrote:
> NetBSD has run the pre-PMF shutdown hooks after panic for years.  I have
> not heard anyone complaining about them.  Is there a particular bug you
> fix by skipping them at panic?
>
> The call to pmf_system_shutdown() is new.  If it causes problems after
> a panic, I believe that this conservative change is more appropriate:
> check for panic and quit after running the "legacy" shutdown hooks,
> but before running pmf_system_shutdown().

The call to doshutdownhooks needs to go away, it breaks the ordering 
requirements of PMF. Consider the following: doshutdownhooks powers off 
fooide0, then pmf_system_shutdown attempts to halt wd0 at fooide0. You're 
probably hosed at this point.

We should probably start complaining about drivers that call 
shutdownhook_establish like we do with powerhook_establish, and stop 
calling them altogether. This should be enough motivation for interested 
parties to convert them to PMF :-)

Cheers,
Jared