Re: CVS commit: src/sys

[Elad Efrat <elad%NetBSD.org@localhost>]

matthew green wrote:
>    matthew green wrote:
>    >    
>    >    Module Name:  src
>    >    Committed By: elad
>    >    Date:         Fri Dec 28 17:14:51 UTC 2007
>    >    
>    >    Modified Files:
>    >          src/sys/kern: exec_elf32.c kern_exec.c kern_pax.c
>    >          src/sys/sys: exec.h
>    >    
>    >    Log Message:
>    >    Provide 8 more bits of stack randomization, from the PaX author.
>    >    
>    >    While here, don't make too much use of one random value, and call
>    >    arc4random() directly. Allows for the removal of 'ep_random' from the
>    >    exec_package.
>    >    
>    >    Prompted by and okay christos@.
>    > 
>    > 
>    > please bump the kernel version.  this change broken old
>    > exec lkm's i believe.
>    > 
>    > thanks.
>    > 
>    > 
>    > .mrg.
>    
>    Why did it break old exec lkm's?
> 
> you changed 'struct exec_package'.

Thought so. I removed a member that was added two days ago:

http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/exec.h.diff?r1=1.118&r2=1.119&f=h

and that change was never accommodated for in the kernel version.

-e.