Re: CVS commit: src/sys/dev/pci

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Wed, Dec 26, 2007 at 04:06:29AM +0000, David Young wrote:
> Log Message:
> Add device suspend/resume/detach.  (Tested with drvctl -S bnx0,
> drvctl -Q bnx0, drvctl -d bnx0.)

Please merge bnx_stop and bnx_if_stop using the interface of the latter.
The bnx_suspend_resume function shouldn't be needed either, as bnx_reset
gets called from if_init with the same argument and bnx_stop supposedly
handles the case for suspend already. If not, it should most likely do
so for disable == 1.

Either bnx_detach (prefered) or bnx_stop need to deal with concurrent
interrupts.

Please add some static here as well.

Joerg