Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys



Module Name:    src
Committed By:   dsl
Date:           Sat Dec 22 16:19:35 UTC 2007

Modified Files:
        src/sys/kern: kern_subr.c kern_systrace.c sys_syscall.c
        src/sys/sys: systm.h systrace.h

Log Message:
Further constification of the syscall args buffer.
It will get __UNCONST() applied in the systrace code if/when systrace tries
to change the arguments.  This sucks since the syscall args might be in
the trap frame, and the syscall might return ERESTART so the restarted call
would use the wrong arguments.
OTOH systrace() (as a security measure) is almost impossible to implement
for a threaded app (validated filenames can be changed before namei() reads
them into memory).
The current code is just plain broken for threaded apps - data that needs
to be lwp-specified is proc-specific.
I believe ad is planning to nuke systrace ...


To generate a diff of this commit:
cvs rdiff -r1.168 -r1.169 src/sys/kern/kern_subr.c
cvs rdiff -r1.78 -r1.79 src/sys/kern/kern_systrace.c
cvs rdiff -r1.4 -r1.5 src/sys/kern/sys_syscall.c
cvs rdiff -r1.205 -r1.206 src/sys/sys/systm.h
cvs rdiff -r1.24 -r1.25 src/sys/sys/systrace.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index