Re: CVS commit: src/sys/rump/fs/lib/liblfs

[Antti Kantee <pooka%cs.hut.fi@localhost>]

On Wed Dec 12 2007 at 21:11:46 +0200, Elad Efrat wrote:
> Antti Kantee wrote:
> > On Wed Dec 12 2007 at 18:52:00 +0000, Elad Efrat wrote:
> >> Module Name:       src
> >> Committed By:      elad
> >> Date:              Wed Dec 12 18:52:00 UTC 2007
> >>
> >> Modified Files:
> >>    src/sys/rump/fs/lib/liblfs: Makefile
> >>
> >> Log Message:
> >> Don't compile lfs_rfw.c, suggested by cube@.
> > 
> > Why?
> 
> Because it breaks the build.
> 
> Rump will try to build it, but will end up with this:
> 
> sys/rump/fs/lib/liblfs/liblfs.a(lfs_rfw.o): In function `lfs_roll_forward':
> /usr/src/sys/ufs/lfs/lfs_rfw.c:617: undefined reference to `lfs_do_rfw'
> 
> Because lfs_rfw.c is conditionally compiled only when LFS_KERNEL_RFW is
> enabled. Since it isn't in the liblfs Makefile, you're not getting
> "lfs_do_rfw" from lfs_vfsops.c.
> 
> Needless to say I care less whether this is reverted in favor of
> -DLFS_KERNEL_RFW in the Makefile or not :) but that's just what cube@
> suggested.

ic.  I'd like to fix this another way and get rid of LFS_KERNEL_RFW
completely since seems it's runtime-controlled.  Or nuke the code if it
doesn't work.  YASI (Yet Another Stupid Ifdef)

-- 
Antti Kantee <pooka%iki.fi@localhost>                     Of course he runs 
NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"