Subject: Re: CVS commit: src/sys/ufs
To: Jared D. McNeill <jmcneill@invisible.ca>
From: Luke Mewburn <lukem@NetBSD.org>
List: source-changes
Date: 12/12/2007 14:46:27
--aVD9QWMuhilNxW9f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 11, 2007 at 10:11:24PM -0500, Jared D. McNeill wrote:
  | On Wed, 12 Dec 2007, Luke Mewburn wrote:
  | >Log Message:
  | >defflag LFS_KERNEL_RFW (in opt_lfs.h).
  | >Note: lfs_rfw.c doesn't compile if you define the option; locking API=
=20
  | >fallout?
  |=20
  | On -current amd64:
  |=20
  | ../../../../ufs/lfs/lfs_rfw.c: In function 'lfs_rf_valloc':
  | ../../../../ufs/lfs/lfs_rfw.c:134: error: too many arguments to functio=
n=20
  | 'lfs_truncate'
  | ../../../../ufs/lfs/lfs_rfw.c: In function 'update_inoblk':
  | ../../../../ufs/lfs/lfs_rfw.c:344: error: too many arguments to functio=
n=20
  | 'lfs_truncate'
  | cc1: warnings being treated as errors
  | ../../../../ufs/lfs/lfs_rfw.c: In function 'check_segsum':
  | ../../../../ufs/lfs/lfs_rfw.c:472: warning: pointer of type 'void *' us=
ed=20
  | in arithmetic
  | ../../../../ufs/lfs/lfs_rfw.c:472: warning: pointer of type 'void *' us=
ed=20
  | in arithmetic
  | ../../../../ufs/lfs/lfs_rfw.c:476: warning: pointer of type 'void *' us=
ed=20
  | in arithmetic
  | ../../../../ufs/lfs/lfs_rfw.c:492: warning: pointer of type 'void *' us=
ed=20
  | in arithmetic
  | *** Error code 1

Yes; that file has been broken for a while.

Prior to my change, the .o file was being compiled with 0 contents.
Now it won't be compiled at all unless LFS_KERNEL_RFW is defined
in your kernel config.

Maybe there's some stale files left around in your kernel build
directory.  Did you rerun config(1) first?

--aVD9QWMuhilNxW9f
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (NetBSD)

iD8DBQFHX1mSpBhtmn8zJHIRAmVfAKCc9L4jvdITJQU0ge+++2xE1DkFBwCeLgm+
cjwerkVKr5/1IHql92C0Kq0=
=fgxd
-----END PGP SIGNATURE-----

--aVD9QWMuhilNxW9f--