Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/make



On Thu, 11 Oct 2007, Simon J. Gerraty wrote:
>       src/usr.bin/make: job.c
> 
> Log Message:
> If _BASENAME_DEFSHELL is defined, it might be a full path,
> in which case we should not prepend _PATH_DEFSHELLDIR.

If you do that, please rename the variable.  It's confusing to have a
variable whose name includes "BASENAME" but whose value is not always a
basename.

--apb (Alan Barrett)



Home | Main Index | Thread Index | Old Index