Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/netbt



On Mon Sep 17 2007 at 04:56:12 +0300, Antti Kantee wrote:
> > Log Message:
> > Macros that are meant for statements (instead of expressions) SHALL
> > never be defined to an empty string, because in that case,
> > 
> >     if (condition) DPRINTF(...); else err(...);
> > 
> > results in a gcc warning, and possibly worse things.
> 
> Are you going to change the 32 billion other empty DPRINTF's also? ;)
> 
> I can't think of any reason why someone would want such a construct.
> Where is the code?

Hmm, I wonder how I read that.  Nevermind.  I guess I should try sleep ;)

-- 
Antti Kantee <pooka%iki.fi@localhost>                     Of course he runs 
NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"



Home | Main Index | Thread Index | Old Index