Subject: Re: CVS commit: src/sys/dist/ipf/netinet
To: Pavel Cahyna <pavel@netbsd.org>
From: Darren Reed <darrenr@netbsd.org>
List: source-changes
Date: 09/17/2007 22:15:33
Pavel Cahyna wrote:
> On Mon, Sep 17, 2007 at 06:25:24AM +0000, Martti Kuparinen wrote:
> >
> > Module Name: src
> > Committed By: martti
> > Date: Mon Sep 17 06:25:24 UTC 2007
> >
> > Modified Files:
> > src/sys/dist/ipf/netinet: fil.c ip_fil_netbsd.c
> >
> > Log Message:
> > Returning from m_pulldown can leave the first mbut with no data (m_len = 0).
> > The mbuf chain wasn't being walked and thus fin_m was not updated to point
> > to the new first mbuf with data in it.
>
> Don't you leak the first mbuf in the chain when walking it like that?
>
No. The top of the mbuf chain is stored in *fin->fin_mp and
fin->fin_m points to the mbuf where the packet starts.
Darren