Subject: Re: CVS commit: src/sys/dev/ata
To: David Laight <david@l8s.co.uk>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: source-changes
Date: 09/17/2007 10:56:42
On Sun, Sep 16, 2007 at 10:43:19PM +0100, David Laight wrote:
> On Sun, Sep 16, 2007 at 06:41:48PM +0000, Manuel Bouyer wrote:
> > 
> > Module Name:	src
> > Committed By:	bouyer
> > Date:		Sun Sep 16 18:41:48 UTC 2007
> > 
> > Modified Files:
> > 	src/sys/dev/ata: wd.c
> > 
> > Log Message:
> > Add a workaround for drives with the LBA48 bug:
> > if we get a "ID not found" error for a transfer crossing LBA48_THRESHOLD,
> > and the drive is larger than 128GB, automatically add WD_QUIRK_FORCE_LBA48
> > to the drive's quirks and retry the transfers.
> > Hopefully this will obsolete the WD_QUIRK_FORCE_LBA48 quirk list ...
> 
> Did I remember something about a disk that managed to write to sector zero?
> In which case should we be using LBA48 for any transfer that crosses the
> boundary regardless as to any previous failure?

From my understanding, this brocken drive did so only for the
last retry, when the driver does the transfer in single-sector PIO mode.
With the hack I added, it should not go there ...

-- 
Manuel Bouyer, LIP6, Universite Paris VI.           Manuel.Bouyer@lip6.fr
     NetBSD: 26 ans d'experience feront toujours la difference
--