Subject: Re: CVS commit: src/sys/netbt
To: Roland Illig <rillig@netbsd.org>
From: Antti Kantee <pooka@cs.hut.fi>
List: source-changes
Date: 09/17/2007 04:56:12
On Mon Sep 17 2007 at 01:23:17 +0000, Roland Illig wrote:
> 
> Module Name:	src
> Committed By:	rillig
> Date:		Mon Sep 17 01:23:17 UTC 2007
> 
> Modified Files:
> 	src/sys/netbt: bluetooth.h
> 
> Log Message:
> Macros that are meant for statements (instead of expressions) SHALL
> never be defined to an empty string, because in that case,
> 
> 	if (condition) DPRINTF(...); else err(...);
> 
> results in a gcc warning, and possibly worse things.

Are you going to change the 32 billion other empty DPRINTF's also? ;)

I can't think of any reason why someone would want such a construct.
Where is the code?

-- 
Antti Kantee <pooka@iki.fi>                     Of course he runs NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"