Jeff Rizzo wrote:

> Module Name:	src
> Committed By:	riz
> Date:		Sat Sep  1 22:19:25 UTC 2007
> 
> Modified Files:
> 
> 	src/sys/dev/i2c: i2c.c
> 	src/sys/dev/pci: ichsmb.c nfsmb.c
> 
> Log Message:
> 
> For SMBus, add the ability to enumerate devices on the bus.
> This does NOT identify the devices, merely indicates the
> presence of devices at certain addresses.  Tested on ichsmb
> and nfsmb - other SMBus devices will need to ensure the
> proper bus type is set. (I2C_TYPE_SMBUS)
> 
> >From Nicolas Joly, via Paul Goyette, in PR#36744.

For reasons I can not fathom, this change causes my Dell 640m laptop
to powerdown when I use reboot(8), instead of rebooting normally.
This happens with both UP and MP kernels, and both on HEAD and on the
jmcneill-pm branch.

Here's some dmesg:

   pci0 at mainbus0 bus 0: configuration mode 1
   pci0: i/o space, memory space enabled, rd/line, rd/mult, wr/inv ok
   pci0: generic device class power management enabled
   pci0: supported states: D0 D3
   pchb0 at pci0 dev 0 function 0
   pchb0: Intel 82945GM/PM/GMS Host Bridge (rev. 0x03)
      ...
   ichsmb0 at pci0 dev 31 function 3: Intel 82801GB/GR SMBus Controller (rev. 0x01)
   ichsmb0: interrupting at ioapic0 pin 17 (irq 4)
   iic0 at ichsmb0: I2C bus
   iic0: WARNING: power management not supported
   ichsmb0: WARNING: power management not supported

I can include full dmesg if needed.

For now, I've just commented out the

	iba.iba_type = I2C_TYPE_SMBUS;

sys/dev/pci/ichsmb.c and that gets things working for me again.

I've no idea what do about this...  Should I at least reopen the PR?

Simon.