Re: CVS commit: src/sbin/fdisk

["Valeriy E. Ushakov" <uwe%stderr.spb.ru@localhost>]

On Tue, Sep 04, 2007 at 16:30:59 +0200, Joerg Sonnenberger wrote:

> On Tue, Sep 04, 2007 at 12:34:58AM +0000, Thor Lancelot Simon wrote:
> > Log Message:
> > This program is a host tool, so when we use newfangled C features like
> > PRIxyz we have to ensure it still builds on hosts with Old compilers.
> > Noticed while building a cross-toolchain on FreeBSD 4.
> 
> If we want to work around issues like this,
> src/tools/compat/compat_defs.h seems to be a much better place to do it.

I guess I'm to blame for setting the precedent, b/c I've added PRId64
there some time ago (for FreeBSD 4 host too).

However in this specific case I wonder

. if using PRI macro is necessary at all and if just using int
  wouldn't be enough (I don't think we support hosts with ints
  narrower than 32-bit anyway).

. why compat macro is defined as a "long" format?

. why an unsigned value is printed using a signed format?  (which has
  nothing to do with the discussed change, but while we are here...)

SY, Uwe
-- 
uwe%stderr.spb.ru@localhost                       |       Zu Grunde kommen
http://snark.ptc.spbu.ru/~uwe/          |       Ist zu Grunde gehen