Subject: Re: CVS commit: src/sys/dev/onewire
To: Juan Romero Pardines <xtraeme@netbsd.org>
From: Antti Kantee <pooka@cs.hut.fi>
List: source-changes
Date: 09/02/2007 12:33:18
On Sun Sep 02 2007 at 00:55:33 +0000, Juan Romero Pardines wrote:
>
> Module Name: src
> Committed By: xtraeme
> Date: Sun Sep 2 00:55:33 UTC 2007
>
> Modified Files:
> src/sys/dev/onewire: onewire.c
>
> Log Message:
> Convert onewire(4) to use rwlock(9) rather than lockmgr(9).
>
>
> To generate a diff of this commit:
> cvs rdiff -r1.5 -r1.6 src/sys/dev/onewire/onewire.c
You changed the return value of onewire_lock, now 0 is both for success
and failure.
Also, is there some reason for using a reader/writer lock when it's
always locked exclusively?
--
Antti Kantee <pooka@iki.fi> Of course he runs NetBSD
http://www.iki.fi/pooka/ http://www.NetBSD.org/
"la qualité la plus indispensable du cuisinier est l'exactitude"