Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/common



On Fri, Aug 17, 2007 at 07:26:07AM +0000, Tom Spindler wrote:
> > Log Message:
> > boolean_t -> bool
> > TRUE -> true
> > FALSE -> false
> 
> Since the proplib headers are included by nearly everything now
> (if you include lwp or fcntl, proplib gets included), and
> prop/prop_object.h pulls in <stdbool.h>, "bool" is now
> visible ~everywhere in the tree; this breaks myriad programs -
> veriexxec, btdevctl, am-utils, msgs, etc that have pre-C9x behavior.

Should be ioctl, not fcntl, and it includes proplib.h via dkio.h which
needs struct plistref. As struct plistref does not reference any proplib
data type, it could be split out to a separate header file which dkio.h
would include instead of proplib.h to reduce namespace pollution.

Pavel



Home | Main Index | Thread Index | Old Index