Re: CVS commit: src/sys/kern

[Antti Kantee <pooka%netbsd.org@localhost>]

On Mon Aug 13 2007 at 07:49:14 +0900, YAMAMOTO Takashi wrote:
> > Log Message:
> > CREATE is a write operation in my book, so check for that also when
> > checking for a readonly lookup.  This shouldn't make a difference
> > now, though, as the only RDONLY lookup is done by getcwd(), and
> > that a) doesn't create files b) calls LOOKUP directly anyway.
> > 
> > Also, fix comment I managed to miss in the previous commit (I didn't
> > expect the same comment to be there twice).
> > 
> > 
> > To generate a diff of this commit:
> > cvs rdiff -r1.94 -r1.95 src/sys/kern/vfs_lookup.c
> > 
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
> 
> RDONLY is used by nfsd.

Ah, good to know, missed that :(

> doesn't it break EEXIST cases?

What do you mean specifically?  Trying to create a node which already
exists on a readonly nfs mount?  Yes, I think might now return EROFS
instead of EEXIST.  I'll revert that part.  thanks.

-- 
Antti Kantee <pooka%iki.fi@localhost>                     Of course he runs 
NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"