Subject: Re: CVS commit: src/lib/libpthread
To: Andrew Doran <ad@NetBSD.org>
From: Bernd Ernesti <netbsd@lists.veego.de>
List: source-changes
Date: 08/04/2007 19:27:00
Hi Andrew,

On Sat, Aug 04, 2007 at 01:37:51PM +0000, Andrew Doran wrote:
> 
> Module Name:	src
> Committed By:	ad
> Date:		Sat Aug  4 13:37:51 UTC 2007
> 
> Modified Files:
> 	src/lib/libpthread: pthread.c pthread_barrier.c pthread_cond.c
> 	    pthread_int.h pthread_lock.c pthread_mutex.c pthread_rwlock.c
> 	    pthread_types.h sem.c
> 
> Log Message:
> Some significant performance improvements, and a fix for a race with pthread
> detach/join.

Cool, but I'm having some compile problems:

/src/lib/libpthread_dbg/pthread_dbg.c(203): incomplete structure or union pthread_queue_t: allq [31]
/src/lib/libpthread_dbg/pthread_dbg.c(206): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(210): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(232): incomplete structure or union pthread_queue_t: queue [31]
/src/lib/libpthread_dbg/pthread_dbg.c(278): undefined struct/union member: pt_joiners [101]
/src/lib/libpthread_dbg/pthread_dbg.c(278): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(283): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(406): incomplete structure or union pthread_queue_t: queue [31]
/src/lib/libpthread_dbg/pthread_dbg.c(408): undefined struct/union member: pt_joiners [101]
/src/lib/libpthread_dbg/pthread_dbg.c(408): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(413): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(436): incomplete structure or union pthread_queue_t: queue [31]
/src/lib/libpthread_dbg/pthread_dbg.c(452): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(457): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(486): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(490): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(510): undefined struct/union member: pt_joiners [101]
/src/lib/libpthread_dbg/pthread_dbg.c(510): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(515): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(521): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(525): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(528): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(532): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(571): incomplete structure or union pthread_queue_t: queue [31]
/src/lib/libpthread_dbg/pthread_dbg.c(580): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(586): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(593): undefined struct/union member: pt_joiners [101]
/src/lib/libpthread_dbg/pthread_dbg.c(593): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(602): illegal member use: ptqh_first [102]
/src/lib/libpthread_dbg/pthread_dbg.c(669): incomplete structure or union pthread_queue_t: allq [31]
/src/lib/libpthread_dbg/pthread_dbg.c(673): cannot take size of incomplete type [143]
/src/lib/libpthread_dbg/pthread_dbg.c(679): illegal member use: ptqh_first [102]
*** Error code 1

It looks like you forgot to modify libpthread_dbg.

Regards,
Bernd