Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/sgimips/hpc



he%NetBSD.org@localhost wrote:

> Module Name:  src
> Committed By: he
> Date:         Mon Jul 23 22:28:23 UTC 2007
> 
> Modified Files:
>       src/sys/arch/sgimips/hpc: haltwo.c hpc.c hpcdma.c
> 
> Log Message:
> After move to 64-bit paddr_t, cast via vaddr_t before casting to void*.
> OK'ed by macallan@.

In hpc.c and hpcdma.c case, they look actually physical addresses
limited in 32bit range, so uint32_t casts are appropriate rather
than vaddr_t.

In haltwo.c case, they are abuse of bus_space_handle_t so maybe
we should use bus_space_vaddr(9) (which is not implemented for hpc),
but anyway I wonder if 64bit offset is actually needed for ha_devoff
to map device spaces.
---
Izumi Tsutsui



Home | Main Index | Thread Index | Old Index