Subject: Re: CVS commit: src/sys/arch/sgimips/include
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Michael Lorenz <macallan@netbsd.org>
List: source-changes
Date: 07/23/2007 10:08:27
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Jul 23, 2007, at 06:16, Izumi Tsutsui wrote:

> macallan@NetBSD.org wrote:
>
>> Module Name:	src
>> Committed By:	macallan
>> Date:		Mon Jul 23 00:45:52 UTC 2007
>>
>> Modified Files:
>> 	src/sys/arch/sgimips/include: loadfile_machdep.h
>>
>> Log Message:
>> sprinkle (vaddr_t) to deal with sizeof(paddr_t) != sizeof(void *)
>> Now the loader should build again.
>
> I think libsa/loadfile_aout.c should be fixed rather than
> MD loadfile_machdep.h. It looks all paddr_t variables in
> loadfile_aout.c should be vaddr_t because they are
> used as addresses with paddr_t == vaddr_t mappings.

I agree.

> Anyway, I don't think sgimips requires BOOT_AOUT support though.

I left that in place because I wasn't sure it's needed - I know of SGI 
firmware using ELF or ECOFF - no idea about a.out.

have fun
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)

iQEVAwUBRqS2W8pnzkX8Yg2nAQIcOAf/RS4xaTI8q6xfAIwEdPjbucBK0Y4m4NFR
UmqKT8zIxETe2v//nHr+GVrNbUtyOB0JVeJjxRAxmeDAdgPPMRnpsWjD0EIM6/HL
TvWZrCAOVMRxVHtSfQmEJgngInBiT8vMSXvICYtauf17VJWcGcsIUYCTa5P+hERU
KvH50BcYJ90NQ0ehL/Gc5F4VvSyOPVoHOZiBC6HD6oKNfVkqC9f9QeBxVO5NbW5g
64ktNBJnNbapQXWYXULGbufoHVjA8rZyTt5jjaCHF0Vv4TV62q7J/BvsTsrFiIAv
Cvts0b1Wcl5TsttqdqlBPvZgFgzDMrzNtXQWWGbJX3jI51qvTv71fg==
=qJ+u
-----END PGP SIGNATURE-----