Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/envstat



On Thu, Jul 05, 2007 at 02:39:48PM +0200, Juan RP wrote:
> On Thu,  5 Jul 2007 21:15:49 +0900 (JST)
> yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> 
> > > Module Name:      src
> > > Committed By:     xtraeme
> > > Date:             Thu Jul  5 12:11:05 UTC 2007
> > > 
> > > Modified Files:
> > >   src/usr.sbin/envstat: envstat.c
> > > 
> > > Log Message:
> > > Print 'N/A' for invalid sensors rather than an asterisk, with the
> > > exception of Indicator sensors.
> > > 
> > > Indicator sensors now will print "ON" if they are in valid state, or
> > > "OFF" if they are in invalid state.
> > 
> > why do you want to make indicator an exception?
> 
> Again?? I think the consensus was clear in your previous email.
> 
> You WANT to see if the Indicator is OFF or ON, not with "N/A" when it's
> invalid, otherwise it should not be an Indicator.

What I don't understand here is why you don't want to have three states
there:  1.  envsys knows the value, it's on.  2.  envsys knows the
value, it's off.  3.  envsys doesn't know the value.

In this scenario N/A is a wholly different value than OFF.

I'm not saying that we can't have the two merged, but then I don't get
why the API offers a field for a value _and_ a field for the validity of
the said value.

And I'm pretty sure I've expressed that opinion to you before, albeit
not on a public list, but a lot before you asked for a final round of
comments.

-- 
Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.

Attachment: pgpFssBejGySu.pgp
Description: PGP signature



Home | Main Index | Thread Index | Old Index