Subject: Re: CVS commit: src/usr.sbin/envstat
To: Juan RP <juan@xtrarom.org>
From: Quentin Garnier <cube@cubidou.net>
List: source-changes
Date: 07/05/2007 15:05:07
--opg8F0UgoHELSI+9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 05, 2007 at 02:39:48PM +0200, Juan RP wrote:
> On Thu,  5 Jul 2007 21:15:49 +0900 (JST)
> yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:
>=20
> > > Module Name:	src
> > > Committed By:	xtraeme
> > > Date:		Thu Jul  5 12:11:05 UTC 2007
> > >=20
> > > Modified Files:
> > > 	src/usr.sbin/envstat: envstat.c
> > >=20
> > > Log Message:
> > > Print 'N/A' for invalid sensors rather than an asterisk, with the
> > > exception of Indicator sensors.
> > >=20
> > > Indicator sensors now will print "ON" if they are in valid state, or
> > > "OFF" if they are in invalid state.
> >=20
> > why do you want to make indicator an exception?
>=20
> Again?? I think the consensus was clear in your previous email.
>=20
> You WANT to see if the Indicator is OFF or ON, not with "N/A" when it's
> invalid, otherwise it should not be an Indicator.

What I don't understand here is why you don't want to have three states
there:  1.  envsys knows the value, it's on.  2.  envsys knows the
value, it's off.  3.  envsys doesn't know the value.

In this scenario N/A is a wholly different value than OFF.

I'm not saying that we can't have the two merged, but then I don't get
why the API offers a field for a value _and_ a field for the validity of
the said value.

And I'm pretty sure I've expressed that opinion to you before, albeit
not on a public list, but a lot before you asked for a final round of
comments.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.

--opg8F0UgoHELSI+9
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (NetBSD)

iQEVAwUBRozsg9goQloHrPnoAQIoyQf/ftpFWDiD89BTIO23JeiVQ5PwGN20tsst
1LCeetDnTxZOu+3rni/YloAwpp1zMOhKo8i+mBbdCnMEDxUpUZDRZ/xVHi1ZqrFG
rjgqrJxojhaEMz1LVa/qTfGNTazGC35QLPy0/zHXQYEF/wwddJiFON84iS2jSTyY
OKTIOsrBmqfpIkqDcDjfX1SmyOvhBWiVpk0BkSmSAsBRxSlijpDCGrQ3lRpZq/wE
4GB3f9IDInfD2E73IYj3VGQZE0Os0VwhAQWBJVjRzXTqbxFchGwOlbkkvPJ5RVD3
ca9m739t2QleHNDcwixwqqMNnYtCc2ILZk19JjxqVVkf6kNuJ2LeOQ==
=6f9m
-----END PGP SIGNATURE-----

--opg8F0UgoHELSI+9--