Subject: Re: CVS commit: src/usr.sbin/envstat
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Juan RP <juan@xtrarom.org>
List: source-changes
Date: 07/05/2007 11:51:15
On Thu,  5 Jul 2007 18:44:36 +0900 (JST)
yamt@mwd.biglobe.ne.jp (YAMAMOTO Takashi) wrote:

> why not for indicators?
> 
> > Except Integer and Driver sensors, which shouldn't need that.
> 
> can you explain?

That should be "Integer and Drive sensors".

Because I can't see any reason why these sensors should be shown when they
are in invalid state.

Drive sensors do not rely in the state field to report if a drive is online
or not, they use value_cur for this.

Showing Indicator sensors if they are disabled is ugly and I would like to
not change many drivers only for this, I have explained the reason in a PR
to Greg. A. Woods before.

If we show invalid Indicator sensors, acpiacad would report:

acpiacad0 connected
acpiacad0 disconnected: *

and acpibat:

acpibat0 charging
acpibat0 discharging: *

Do you really want this? I don't.

-- 
Juan Romero Pardines	- The NetBSD Project
http://plog.xtrarom.org	- NetBSD/pkgsrc news in Spanish