Subject: Re: CVS commit: [itohy-usb1] src/sys/dev/usb
To: None <itohy@netbsd.org>
From: None <david.sainty@dtsp.co.nz>
List: source-changes
Date: 06/25/2007 23:37:53
ITOH Yasufumi writes:

> 
> Module Name:	src
> Committed By:	itohy
> Date:		Mon Jun 25 09:21:28 UTC 2007
> 
> Modified Files:
> 	src/sys/dev/usb [itohy-usb1]: if_axe.c
> 
> Log Message:
> Add support of AX88178 and AX88772 (based on OpenBSD).
> (beware new Tx/Rx code, totally untested)
>
> To generate a diff of this commit:
> cvs rdiff -r1.17.10.5 -r1.17.10.6 src/sys/dev/usb/if_axe.c

Brilliant!  I have been working on this, and throwing up my hands in
horror over the slapstick OpenBSD changes!  Not to mention the nasty
state of the device definitions added for this driver in the OpenBSD
usbdevs (dups, definitions all over the place).

Your code looks a lot nicer than theirs!  Thanks!

(now if only the chip init routines grew a few less magic numbers :)