Subject: Re: CVS commit: src/sys/miscfs/procfs
To: Mindaugas Rasiukevicius <rmind@netbsd.org>
From: Antti Kantee <pooka@cs.hut.fi>
List: source-changes
Date: 04/04/2007 07:03:15
On Wed Apr 04 2007 at 01:27:34 +0000, Mindaugas Rasiukevicius wrote:
> 
> Module Name:	src
> Committed By:	rmind
> Date:		Wed Apr  4 01:27:33 UTC 2007
> 
> Modified Files:
> 	src/sys/miscfs/procfs: procfs_vnops.c
> 
> Log Message:
> procfs_readlink: Handle a possible fail of fd_getfile(), also, we
> do not need to check for error again.
> CID: 4436
> 
> 
> To generate a diff of this commit:
> cvs rdiff -r1.154 -r1.155 src/sys/miscfs/procfs/procfs_vnops.c

Shouldn't you unlock proc in the error branch?

-- 
Antti Kantee <pooka@iki.fi>                     Of course he runs NetBSD
http://www.iki.fi/pooka/                          http://www.NetBSD.org/
    "la qualité la plus indispensable du cuisinier est l'exactitude"